Migrate EC support to Rust #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
rust-ec
branch
6 times, most recently
from
1e6f9e6
to
751388c
Compare
alex
force-pushed
the
rust-ec
branch
11 times, most recently
from
80e407e
to
2b1ef37
Compare
|
Note to self: Do we have a test that verifies that we always serialize in named curve form? |
reaperhulk
reviewed
Jun 21, 2023
| let valid = verifier.verify(data, signature).unwrap_or(false); | ||
| // TODO: Empty the error stack. BoringSSL leaves one in the event of | ||
| // signature validation failure. Upstream to rust-openssl? | ||
| openssl::error::ErrorStack::get(); |
There was a problem hiding this comment.
Should we annotate this for just boring?
There was a problem hiding this comment.
Done, but also, what do you think about upstreaming?
There was a problem hiding this comment.
I think we should upstream. Without doing so every caller needs to know that they need this conditional or else their error stack gets polluted and who knows what their error handling does.
reaperhulk
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.